address intermittent failure in metrics command #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an intermittent issue where the perfspect metrics command fails to exit when a workload specified on the command line completes. The root cause is identified as a potentially blocked unbuffered channel that receives stdout.
Key changes:
- Added a goroutine to drain the stdout channel to prevent blocking when workloads write to stdout
- Renamed
argsApplicationtoargsWorkloadthroughout for consistency - Updated user-facing messages to reflect "workload" terminology
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/metrics/perf.go | Renamed argsApplication to argsWorkload and cleaned up commented code |
| cmd/metrics/metrics.go | Added stdout draining goroutine, renamed application terminology to workload, and updated validation messages and user prompts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rare occasions, perfspect metrics will fail to exit when a workload specified on the command line exits.
Example:
perfspect metrics -- stress-ng --cpu 4 --timeout 20
The functional change made in this PR is to drain the unbuffered channel that receives stdout as it could become blocked if stress-ng (as above) writes to stdout, which might prevent the processes from exiting cleanly. It's a theory at this point, as the issue is intermittent.