fix exports matching #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the usage of `esmock` with the latest version of `@modelcontextprotocol/sdk`, which introduced new exports entries. See: modelcontextprotocol/typescript-sdk#851
matz3
force-pushed
the
fix-exports-matching
branch
from
6f13213 to
a2c2773
Compare
Owner
|
Thanks for submitting this. Haven't looked at this locally, so excuse me if I'm missing something obvious --could the new assertions and test be added without removing or modifying the existing assertions/tests? |
matz3
commented
Sep 1, 2025
Contributor
Author
|
@iambumblehead thanks for the quick feedback. I've posted some comments in the code. |
Owner
|
thanks for the response. Would like to investigate this later (today) to better understand why the existing test fails |
Owner
|
all esmock tests pass using changes here. will merge and publish soon |
Owner
|
updating esmock to use latest version with this change iambumblehead/esmock#325 |
Owner
|
[email protected] is published |
Contributor
Author
|
@iambumblehead wow, thank you for the quick release 👍🏻 |
Owner
|
@matz3 thanks for spending energy looking at the sources and resolving the issue with them |
d3xter666
pushed a commit
to UI5/mcp-server
that referenced
this pull request
Sep 17, 2025
d3xter666
pushed a commit
to UI5/mcp-server
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the usage of
esmockwith the latest version of@modelcontextprotocol/sdk, which introduced new exports entries.See: modelcontextprotocol/typescript-sdk#851