Fix add_dates script: Fetch github repo from url to check if model is new #42878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
reviewed
Dec 16, 2025
Comment on lines
+77
to
+84
| except Exception as e: | ||
| # Handle all other errors (network issues, timeouts, etc.) | ||
| print( | ||
| f"Warning: Could not verify file existence on GitHub: {url}\n" | ||
| f"Error: {e}\n" | ||
| f"Assuming file exists and continuing with local git history." | ||
| ) | ||
| return True |
Contributor
There was a problem hiding this comment.
not sure I understand, if there's a timeout or anything we assume file exists anyways?
Member
Author
There was a problem hiding this comment.
Yes that's the conservative fallback, instead of always overriding with today's date (which is what happens when the file isn't found) when there's an error
Member
There was a problem hiding this comment.
isn't it going to err out later when we try to get the first commit adding the (maybe non-existent?) model
Member
Author
There was a problem hiding this comment.
It will use the local git history for this so it should be alright
zucchini-nlp
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, we used to fetch the repo with upstream/main, which doesn't work if the repo is not forked (?).
This way should be more robust