-
-
Notifications
You must be signed in to change notification settings - Fork 434
Update VSCode Prettier extension and GitHub Actions versions #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Prettier extension references from 'prettier.prettier-vscode' to 'esbenp.prettier-vscode' in VSCode config files. Updated GitHub Actions in documentation to use specific commit SHAs for improved security and reproducibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the VSCode configuration to use the new official Prettier extension, which is a good maintenance task. It also aims to improve security in the GitHub Actions documentation by pinning actions to specific commit SHAs instead of floating tags. However, the implementation for the GitHub Actions update is critically flawed. The commit SHAs provided for actions/checkout and actions/setup-node are invalid and will cause the example workflow to fail for users. I've provided suggestions with correct, stable versions and their corresponding SHAs. Additionally, the version comment for the upload-sarif action is confusing and should be clarified.
Deploying htmlhint with
|
| Latest commit: |
e8f6abe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68019815.htmlhint.pages.dev |
| Branch Preview URL: | https://dev-coliff-scanning-docs.htmlhint.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates GitHub Actions references in documentation to use commit SHAs for better security and reproducibility, and corrects the VSCode Prettier extension identifier to use the current standard format.
Changes:
- Updated GitHub Actions in documentation to use specific commit SHAs with version comments
- Changed Prettier extension ID from
prettier.prettier-vscodetoesbenp.prettier-vscodein VSCode configuration files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website/src/content/docs/usage/github-code-scanning.mdx | Updated GitHub Actions to use SHA-pinned versions in documentation example |
| .vscode/settings.json | Updated Prettier extension identifier in editor default formatter configuration |
| .vscode/extensions.json | Updated Prettier extension identifier in recommended extensions list |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
===========================================
+ Coverage 96.99% 100.00% +3.00%
===========================================
Files 2 1 -1
Lines 1628 1 -1627
Branches 335 0 -335
===========================================
- Hits 1579 1 -1578
+ Misses 49 0 -49 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Updated GitHub Actions in documentation to use specific commit SHAs for improved security and reproducibility.
Changed Prettier extension references from 'prettier.prettier-vscode' to 'esbenp.prettier-vscode' in VSCode config files.