Skip to content

Conversation

@coliff
Copy link
Member

@coliff coliff commented Feb 2, 2026

Updated GitHub Actions in documentation to use specific commit SHAs for improved security and reproducibility.
Changed Prettier extension references from 'prettier.prettier-vscode' to 'esbenp.prettier-vscode' in VSCode config files.

Changed Prettier extension references from 'prettier.prettier-vscode' to 'esbenp.prettier-vscode' in VSCode config files. Updated GitHub Actions in documentation to use specific commit SHAs for improved security and reproducibility.
Copilot AI review requested due to automatic review settings February 2, 2026 08:10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the VSCode configuration to use the new official Prettier extension, which is a good maintenance task. It also aims to improve security in the GitHub Actions documentation by pinning actions to specific commit SHAs instead of floating tags. However, the implementation for the GitHub Actions update is critically flawed. The commit SHAs provided for actions/checkout and actions/setup-node are invalid and will cause the example workflow to fail for users. I've provided suggestions with correct, stable versions and their corresponding SHAs. Additionally, the version comment for the upload-sarif action is confusing and should be clarified.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 2, 2026

Deploying htmlhint with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8f6abe
Status: ✅  Deploy successful!
Preview URL: https://68019815.htmlhint.pages.dev
Branch Preview URL: https://dev-coliff-scanning-docs.htmlhint.pages.dev

View logs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions references in documentation to use commit SHAs for better security and reproducibility, and corrects the VSCode Prettier extension identifier to use the current standard format.

Changes:

  • Updated GitHub Actions in documentation to use specific commit SHAs with version comments
  • Changed Prettier extension ID from prettier.prettier-vscode to esbenp.prettier-vscode in VSCode configuration files

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
website/src/content/docs/usage/github-code-scanning.mdx Updated GitHub Actions to use SHA-pinned versions in documentation example
.vscode/settings.json Updated Prettier extension identifier in editor default formatter configuration
.vscode/extensions.json Updated Prettier extension identifier in recommended extensions list

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (95e6a13) to head (e8f6abe).
⚠️ Report is 196 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #1796      +/-   ##
===========================================
+ Coverage   96.99%   100.00%   +3.00%     
===========================================
  Files           2         1       -1     
  Lines        1628         1    -1627     
  Branches      335         0     -335     
===========================================
- Hits         1579         1    -1578     
+ Misses         49         0      -49     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a1191...e8f6abe. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coliff coliff merged commit 819b8ee into main Feb 2, 2026
26 checks passed
@coliff coliff deleted the dev/coliff/scanning-docs branch February 2, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants