fix(auth): update code/token generation from CLI and redirect to successful page#518
Open
eduardoRoth wants to merge 7 commits intomainfrom
Open
fix(auth): update code/token generation from CLI and redirect to successful page#518eduardoRoth wants to merge 7 commits intomainfrom
eduardoRoth wants to merge 7 commits intomainfrom
Conversation
…to `cli-log-in` page
eduardoRoth
force-pushed
the
fix/eroth/auth-update
branch
from
c4afd3c to
db76111
Compare
jeremymwells
approved these changes
Mar 18, 2026
Contributor
jeremymwells
left a comment
jeremymwells
left a comment
There was a problem hiding this comment.
LGTM.
Is there no way to test this?
Member
Author
|
@jeremymwells , you can pull this branch and the branch of #350 from
You need to add to your |
Contributor
|
@eduardoRoth - fair point. I meant automated tests. Also, macos, ubuntu, and windows node version tests should pass, right? |
Member
Author
|
@jeremymwells whoops, sorry, i thought you wanted to test it. |
KLongmuirHD
reviewed
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes required by https://github.com/neverendingsupport/eol-report-card/pull/350 to allow users to keep their authenticated session on the web app after a successful authentication from the CLI.
This PR changes the flow for the code and token generation. Before the local server was stopped after the
codefrom keycloak was received, sending atext/painresponse, and generating the tokens after that.The new flow generates the code, then the tokens and, after getting them, it redirects to a page on the
eol-report-cardweb app that handles the creation of the session cookie.