Adding EUVpy. #368
Adding EUVpy. #368
Conversation
|
Hello, Thank you for this PR. EUVpy seems well-poised to join PyHC's ecosystem. I appreciate you following our instructions and doing a self-evaluation. I started using Claude to help evaluate new potential PyHC packages. It generated this review of EUVpy: EUVpy is missing a dedicated CONTRIBUTING.md file and a Contributor Covenant-compatible code of conduct. The Fortran installation complexities are also noticeably worse than other packages that rely on Fortran. For those reasons, I would downgrade Please read Claude's evaluation and tell me if you disagree with anything? Otherwise, update your Community badge and I'd be ready to approve this. Note that approval grants EUVpy inclusion in both the PyHC Documentation Hub and the PyHC Environment. We would also invite you to present your new package at a PyHC telecon. Cheers! |
|
Oh, and we try to keep |
sapols
left a comment
sapols
left a comment
There was a problem hiding this comment.
Please update the Community badge if you agree with Claude's evaluation and move this block to the correct alphabetic location.
|
I totally agree with Claude's feedback. Working this now!
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Tuesday, August 12th, 2025 at 3:04 PM, Shawn Polson ***@***.***> wrote:
@sapols requested changes on this pull request.
Please update the Community badge if you agree with Claude's evaluation and move this block to the correct alphabetic location.
—
Reply to this email directly, [view it on GitHub](#368 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADDO6Z7EV32DQV4J7PTEBTD3NI3DXAVCNFSM6AAAAACDUU4M7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJSGM2TGNRZGA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Okay; I just made the fixes as suggested by Claude; 'Community' has been downgraded to 'Partially met', and the entry for EUVpy has been moved to retain the alphabet structure of projects.yml - it is now right after "enlilviz". |
|
@DanBrandt thanks for the mods based on Shawn/Claude's feedback! It's at the point where I interject myself now and invite you to speak at a PyHC telecon and introduce the package. :) Is your email still the one that is @mtu.edu? |
|
Hi Julie,
And that's right; I'm still at the @mtu address.
Didn't realize that there would be a second telecon invite after the PR (I did one last year introducing the idea of EUVpy, but we hadn't finished everything yet); happy to do that if that's something the PyHC community wants!
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Wednesday, August 13th, 2025 at 11:16 AM, Julie Barnum ***@***.***> wrote:
jibarnum left a comment [(heliophysicsPy/heliophysicsPy.github.io#368)](#368 (comment))
***@***.***(https://github.com/DanBrandt) thanks for the mods based on Shawn/Claude's feedback! It's at the point where I interject myself now and invite you to speak at a PyHC telecon and introduce the package. :) Is your email still the one that is @mtu.edu?
—
Reply to this email directly, [view it on GitHub](#368 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADDO6Z6WLJXEEYLTMN3K42L3NNJDHAVCNFSM6AAAAACDUU4M7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBUGM2DKNRUGM).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
sapols
left a comment
sapols
left a comment
There was a problem hiding this comment.
Thanks Dan! Approved. I'll merge soon (hopefully tomorrow) once I confirm EUVpy makes it into the Documentation Hub and the PyHC Environment successfully.
_data/projects.yml
Outdated
| docs: "https://euvpy.readthedocs.io/en/latest/" | ||
| code: "https://github.com/DanBrandt/EUVpy/tree/main" | ||
| contact: "Daniel Brandt" | ||
| keywords: ["solar", "euv", "irradiance", "flux"] |
There was a problem hiding this comment.
Oh sorry, our automated PR checker just ran and found Unlisted keywords for project EUVpy: {'euv', 'flux', 'irradiance'}
Keywords have to come from our taxonomy. We accept additions to that taxonomy file if you feel a keyword that isn't there should be.
|
Fixing this now!
Sent with [Proton Mail](https://proton.me/mail/home) secure email.
…On Wednesday, August 13th, 2025 at 11:08 PM, Shawn Polson ***@***.***> wrote:
@sapols commented on this pull request.
---------------------------------------------------------------
In [_data/projects.yml](#368 (comment)):
> @@ -159,6 +159,21 @@
python3: ["https://img.shields.io/badge/Good-brightgreen.svg", "Good"]
license: ["https://img.shields.io/badge/Good-brightgreen.svg", "Good"]
+- name: "EUVpy"
+ url: "https://github.com/DanBrandt/EUVpy/tree/main"
+ description: "A Python package containing several models for solar EUV irradiance."
+ logo: https://euvpy.readthedocs.io/en/latest/_images/EUVpy_logo.png
+ docs: "https://euvpy.readthedocs.io/en/latest/"
+ code: "https://github.com/DanBrandt/EUVpy/tree/main"
+ contact: "Daniel Brandt"
+ keywords: ["solar", "euv", "irradiance", "flux"]
Oh sorry, our automated PR checker just ran and found Unlisted keywords for project EUVpy: {'euv', 'flux', 'irradiance'}
Keywords have to come from our [taxonomy](https://github.com/heliophysicsPy/heliophysicsPy.github.io/blob/main/_data/taxonomy.yml). We accept additions to that taxonomy file if you feel a keyword that isn't there should be.
—
Reply to this email directly, [view it on GitHub](#368 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADDO6Z3HXTNUCT2XLXW62733NP4RFAVCNFSM6AAAAACDUU4M7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJYGU2TCMRTHE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Okay I think the keywords should be right now. I just stuck with existing ones rather than add some to the taxonomy file; I figure the community has settled on the existing ones for a good reason. |
|
Great news:
Cheers 🚀 |
3 participants
No description provided.