[Bugfix] HCI response to disconnect of unknown ID should return success.

[h2zero]

• Update macro use to use conversion macros.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of connection and encryption edge cases to make Bluetooth connections more reliable and reduce spurious disconnect errors by treating an additional termination outcome as non-fatal.
• Diagnostics
  • Enhanced failure logging to include both numeric and textual codes for clearer troubleshooting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1be89019-0405-43e0-a83e-daf4d58c9b73

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc8daf and efc8dc2.

📒 Files selected for processing (2)

• src/NimBLEClient.cpp
• src/NimBLEServer.cpp

🚧 Files skipped from review as they are similar to previous changes (2)

• src/NimBLEServer.cpp
• src/NimBLEClient.cpp

---

📝 Walkthrough

Walkthrough

Arrr — Replaced raw HCI error-constant arithmetic with BLE_HS_HCI_ERR(...) checks in client security/connection and gap-handling paths; enhanced secureConnection failure logging to include numeric and string codes; changed client and server disconnect logic to treat BLE_HS_HCI_ERR(BLE_ERR_UNK_CONN_ID) (and some other codes) as non‑fatal and adjust returned result accordingly.

Changes

Cohort / File(s)	Summary
Client connection & error handling src/NimBLEClient.cpp	Replaced raw HCI base+error arithmetic with BLE_HS_HCI_ERR(<BLE_ERR_...>) comparisons in secureConnection, handleGapEvent, and disconnect; added NimBLEUtils::returnCodeToString() to secureConnection failure logging; reworked disconnect to a switch(rc) that treats several return codes as non‑fatal and sets m_connStatus only on successful call.
Server disconnect behavior src/NimBLEServer.cpp	Refactored disconnect return-code handling to switch(rc), treating 0, BLE_HS_ENOTCONN, BLE_HS_EALREADY, and BLE_HS_HCI_ERR(BLE_ERR_UNK_CONN_ID) as non‑fatal (returning true), and logging+returning false for other non‑zero codes.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• [Bugfix] Incorrect Client connection state tracking and self delete #1123 — Modifies NimBLE client/server disconnect handling and error-code checks; overlaps with BLE_ERR_UNK_CONN_ID treatment.
• [Bugfix] Missing notification data when length > 255 bytes #1113 — Touches handleGapEvent in src/NimBLEClient.cpp; related to event-handling adjustments though in a different branch.

Poem

⚓ Arrr, the codes be tidy, no more crude sums,
Errors now named where the HCI wind hums,
Logs shout the number and the tale it tells,
Disconnects loosen ropes and ring the bells,
Avast — smoother seas for BLE's salt drums!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main bugfix: updating HCI error handling for unknown connection IDs to return success, which aligns with the core changes in both NimBLEClient.cpp and NimBLEServer.cpp.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/disconnect-unk-conn-id

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[h2zero]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.