Skip to content

Revert "netty: Preserve early server handshake failure cause in logs"#12669

Merged
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:revert-netty-early-handshake
Feb 27, 2026
Merged

Revert "netty: Preserve early server handshake failure cause in logs"#12669
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:revert-netty-early-handshake

Conversation

@ejona86
Copy link
Member

@ejona86 ejona86 commented Feb 27, 2026

This reverts commit 50ead96. Some users are seeing errors during app development: cl/876319409 b/488103229. Seems related to some internal Google-specific stuff.

FYI @kannanjgithub, @becomeStar (I don't think there's anything more you can do here at the moment; we need to look into it on our side, as it is some very specialized code that is impacted.)

This reverts commit 50ead96.
Some users are seeing errors during app development: cl/876319409
b/488103229. Seems related to some internal Google-specific stuff.
Copy link
Collaborator

@danielzhaotongliu danielzhaotongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ejona86 ejona86 merged commit 09a6e2e into grpc:master Feb 27, 2026
17 checks passed
@ejona86 ejona86 deleted the revert-netty-early-handshake branch February 27, 2026 20:34
@becomeStar
Copy link
Contributor

Thanks for the heads-up — happy to help rework this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants