Skip to content

[Snyk] Fix for 2 vulnerabilities#45

Open
greg-md wants to merge 1 commit intomainfrom
snyk-fix-09bf05a6b4ae04fb80cd0bbf37f349c7
Open

[Snyk] Fix for 2 vulnerabilities#45
greg-md wants to merge 1 commit intomainfrom
snyk-fix-09bf05a6b4ae04fb80cd0bbf37f349c7

Conversation

@greg-md
Copy link
Owner

@greg-md greg-md commented Jan 23, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  713  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  708  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Copilot AI review requested due to automatic review settings January 23, 2026 10:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates npm dependencies to remediate two Snyk-reported vulnerabilities (in tar and diff) by upgrading direct dependencies and regenerating the lockfile.

Changes:

  • Bump @nestjs/graphql from ^7.9.11 to ^8.0.0
  • Bump sinon from ^9.2.4 to ^21.0.1
  • Update package-lock.json to reflect the new resolved dependency graph

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Updates direct dependency versions to address Snyk vulnerabilities.
package-lock.json Refreshes resolved/transitive dependency versions based on the new direct dependency ranges.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"@nestjs/config": "^0.6.3",
"@nestjs/core": "^7.5.1",
"@nestjs/graphql": "^7.9.11",
"@nestjs/graphql": "^8.0.0",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nestjs/graphql was bumped to ^8.0.0, but the project still depends on @nestjs/common/@nestjs/core ^7.x. @nestjs/graphql@8.0.0 declares peer dependencies on @nestjs/common and @nestjs/core ^8.0.0 (see package-lock.json node_modules/@nestjs/graphql -> peerDependencies), so npm install will produce a peer-dependency conflict and can fail with ERESOLVE.

Suggested fix: either upgrade the rest of the NestJS packages to ^8.0.0 (common/core/testing/cli/microservices/platform-fastify, etc.) to keep versions aligned, or keep @nestjs/graphql on a compatible ^7.x version and use npm overrides/other remediation to address the transitive vulnerability instead.

Suggested change
"@nestjs/graphql": "^8.0.0",
"@nestjs/graphql": "^7.11.0",

Copilot uses AI. Check for mistakes.
"rimraf": "^3.0.2",
"rxjs": "^6.6.3",
"sinon": "^9.2.4",
"sinon": "^21.0.1",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sinon is only referenced from test code (e.g. apps/api/src/hello/application/hello.controller.spec.ts), but it is listed under dependencies. This means production installs (e.g. npm ci --omit=dev) will still ship sinon, increasing install size and runtime supply-chain surface.

Suggested fix: move sinon (and likely @types/sinon) to devDependencies since they are test-only.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants