fix: add missing Ignition dependency for HorizonStaking#1305
Open
MoonBoi9001 wants to merge 1 commit intomde/dips-ignition-deploymentfrom
Open
fix: add missing Ignition dependency for HorizonStaking#1305MoonBoi9001 wants to merge 1 commit intomde/dips-ignition-deploymentfrom
MoonBoi9001 wants to merge 1 commit intomde/dips-ignition-deploymentfrom
Conversation
HorizonStaking's constructor extends GraphDirectory, which queries the Controller for GraphToken, EpochManager, RewardsManager, etc. These are registered by GraphPeripheryModule. Without an explicit `after` dependency, Ignition may schedule HorizonStaking before the periphery registrations, causing the constructor to read address(0) and revert with GraphDirectoryInvalidZeroAddress. Every other core module (GraphPayments, PaymentsEscrow, GraphTallyCollector, RecurringCollector) declares this dependency. HorizonStaking was the only outlier. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mde/dips-ignition-deployment #1305 +/- ##
=============================================================
Coverage 81.58% 81.58%
=============================================================
Files 47 47
Lines 2644 2644
Branches 787 787
=============================================================
Hits 2157 2157
Misses 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During local-network testing with fresh contract deployments,
HorizonStakingdeployment intermittently fails withGraphDirectoryInvalidZeroAddress("GraphToken"). The failure is nondeterministic -- it depends on the order Ignition schedules module execution.Summary
HorizonStaking's constructor extends
GraphDirectory, which queries the Controller for GraphToken, EpochManager, RewardsManager, and other periphery contracts. These addresses are registered in the Controller byGraphPeripheryModule. Without an explicitafterdependency, Ignition may schedule HorizonStaking before the periphery registrations complete, causing the constructor to readaddress(0)and revert.Every other core module (
GraphPayments,PaymentsEscrow,GraphTallyCollector,RecurringCollector) already declares{ after: [GraphPeripheryModule, HorizonProxiesModule] }. HorizonStaking was the only one missing it.The fix adds the same dependency declaration to
HorizonStaking.ts. This only affects fresh deployments (new chains, testnets, local environments) -- on mainnet, the Controller already has all addresses registered so the ordering is irrelevant.🤖 Generated with Claude Code