Conversation
Summary of ChangesHello @Natim, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's dependency configuration to remove the upper version limit for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the upper version constraint on the pandas dependency to allow compatibility with pandas 3.0 and later. The change in noxfile.py correctly updates the pre-release testing session to use the latest pandas pre-release, which is a good step for ensuring forward compatibility.
My review includes one suggestion for setup.py. While removing the < 3.0.0 restriction is correct, I recommend adding a new upper bound of < 4.0.0. This is a common best practice that provides stability for users by ensuring compatibility with the pandas 3.x series while preventing unexpected breakages from a future, untested pandas 4.0 major release.
| "numpy >= 1.24.0 ; python_version != '3.10'", | ||
| "packaging >= 24.2.0", | ||
| "pandas >= 1.5.3, < 3.0.0", | ||
| "pandas >= 1.5.3", |
There was a problem hiding this comment.
While this change enables support for pandas 3.0, removing the upper version bound entirely can introduce risk for users. Since db-dtypes is tightly coupled with pandas internals, future major versions of pandas (e.g., 4.0) are likely to have breaking changes that would affect this library.
To provide more stability for users, it's a common best practice to cap the dependency at the next major version. This would allow all pandas 3.x versions but prevent an automatic upgrade to an untested pandas 4.0. It ensures users don't get a broken environment unexpectedly.
| "pandas >= 1.5.3", | |
| "pandas >= 1.5.3, < 4.0.0", |
There was a problem hiding this comment.
We can wait for it to fail to limit it. Since it already covers pandas v1 and v2 there is no need to be so protective at this library level.
IMO, It is the project's responsibility to decide whether they want to upgrade or not. In this case going from v1.4.4 to v1.5.0, rollback to a previous version of pandas in our project while 3.0.0 is already supported.
|
In the meantime I was able to tell my project to override the restriction using: But as you will guess, I would rather not... |
|
Alternatively we can also describe it like that: |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #387 🦕