-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian generate pull request: 20260128T084241Z #15491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request includes several feature additions, documentation updates, and bug fixes across multiple Google Cloud APIs. It introduces new configuration options for Google Container API, enhances personalization in Google Retail API, and improves descriptions in Google Document AI API, among other changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR is an automated update from the Librarian CLI, incorporating a large number of features and documentation updates from upstream protos for various Google Cloud client libraries. The changes span services like Container, Document AI, Network Management, Quotas, Retail, and Grafeas. My review focused on the generated code, particularly on documentation correctness and clarity. I've identified a few typos and formatting issues in the docstrings within the google-cloud-container package that should be addressed to improve readability.
packages/google-cloud-container/google/cloud/container_v1/types/cluster_service.py
Show resolved
Hide resolved
packages/google-cloud-container/google/cloud/container_v1/types/cluster_service.py
Show resolved
Hide resolved
packages/google-cloud-container/google/cloud/container_v1beta1/types/cluster_service.py
Show resolved
Hide resolved
packages/google-cloud-container/google/cloud/container_v1beta1/types/cluster_service.py
Show resolved
Hide resolved
packages/google-cloud-container/google/cloud/container_v1beta1/types/cluster_service.py
Show resolved
Hide resolved
|
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add a user_attributes field in SearchRequest that can be used for personalization
PiperOrigin-RevId: 861314205
Library-IDs: google-cloud-retail
Source-link: googleapis/googleapis@6517e3ba
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a model_scores field in SearchResponse.results to expose model quality signals
PiperOrigin-RevId: 861314205
Library-IDs: google-cloud-retail
Source-link: googleapis/googleapis@6517e3ba
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
last_vulnerability_update_timeis added to message.grafeas.v1.DiscoveryOccurrencePiperOrigin-RevId: 861286340
Library-IDs: grafeas
Source-link: googleapis/googleapis@70da46f8
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
subnetworkin message.google.container.v1beta1.NodeNetworkConfigis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidrin message.google.container.v1beta1.Clusteris changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add GPUDirectConfig to configure GPU Direct for node pools
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add consolidation_delay to configure Cluster Autoscaler node consolidation delay
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SHORT_LIVED as a NodePoolUpdateStrategy
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DRAINING status to AdditionalIPRangesConfig for subnet draining
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DisruptionEvent to provide details on node disruption events
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add shutdown_grace_period_seconds and shutdown_grace_period_critical_pods_seconds to NodeKubeletConfig to configure graceful node shutdown for Spot VMs
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add RegistryHostConfig to ContainerdConfig for containerd registry host configuration
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add NodeDrainConfig to NodePool to configure node draining behavior
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add AutopilotGeneralProfile to ClusterAutoscaling to configure Autopilot profiles
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidr_blockin message.google.container.v1beta1.IPAllocationPolicyis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
node_ipv4_cidr_blockin message.google.container.v1beta1.IPAllocationPolicyis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add ManagedOpenTelemetryConfig to Cluster to manage the OpenTelemetry pipeline
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1beta1.Clusteris changePiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add fields for Rollback-Safe upgrades, including RollbackSafeUpgrade, CompatibilityStatus, and CompleteControlPlaneUpgrade RPC
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1beta1.IPAllocationPolicyis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SliceControllerConfig to AddonsConfig to manage the Slice Controller addon
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidr_blockin message.google.container.v1beta1.IPAllocationPolicyis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Allow specifying subnetwork in NodeNetworkConfig during node pool creation
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidrin message.google.container.v1beta1.Clusteris changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add PodSnapshotConfig to AddonsConfig to manage Pod Snapshots
PiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
sysctlsin message.google.container.v1beta1.LinuxNodeConfigis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
enable_legacy_lustre_portin message.google.container.v1beta1.LustreCsiDriverConfigis changedPiperOrigin-RevId: 859828557
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@6406df78
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add ManagedOpenTelemetryConfig to Cluster to manage the OpenTelemetry pipeline
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidrin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
node_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SHORT_LIVED as a NodePoolUpdateStrategy
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SwapConfig to enable and configure swap memory for node pools
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add consolidation_delay to configure Cluster Autoscaler node consolidation delay
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
sysctlsin message.google.container.v1.LinuxNodeConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SliceControllerConfig to AddonsConfig to manage the Slice Controller addon
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
gcp_secret_manager_certificate_configin message.google.container.v1.ContainerdConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
subnetworkin message.google.container.v1.NodeNetworkConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add GPUDirectConfig to configure GPU Direct for node pools
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DisruptionEvent to provide details on node disruption events
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add AutopilotGeneralProfile to ClusterAutoscaling to configure Autopilot profiles
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Allow specifying subnetwork in NodeNetworkConfig during node pool creation
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidrin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
recurrencein message.google.container.v1.RecurringTimeWindowis changedPiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add NodeDrainConfig to NodePool to configure node draining behavior
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DRAINING status to AdditionalIPRangesConfig for subnet draining
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add RegistryHostConfig to ContainerdConfig for containerd registry host configuration
PiperOrigin-RevId: 859731311
Library-IDs: google-cloud-container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add fields and messages for GKE Pods and IP masquerading
PiperOrigin-RevId: 859595508
Library-IDs: google-cloud-network-management
Source-link: googleapis/googleapis@3343c4ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Fixed language issues in multiple message field descriptions
PiperOrigin-RevId: 859310712
Library-IDs: google-cloud-documentai
Source-link: googleapis/googleapis@64f78809
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Regenerated REST and RPC Document AI documentation to include missing changes from September 2024 to November 2025
PiperOrigin-RevId: 859310712
Library-IDs: google-cloud-documentai
Source-link: googleapis/googleapis@64f78809
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Correct typo in comment for field
quota_idPiperOrigin-RevId: 859139909
Library-IDs: google-cloud-quotas
Source-link: googleapis/googleapis@6b36371f
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@87e3579c
(exclusive) and
googleapis/googleapis@6517e3ba
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:56f26eaebaf1b4a9f174a72e00d091a1364997e17201dbad1aea099ddbda3a3e
Generation failed for