Skip to content

docs(storage control): retain jsdocs for overloads and only generate docs for uber stor…#7023

Merged
ddelgrosso1 merged 2 commits intomainfrom
fix-storage-control-docs
Jan 28, 2026
Merged

docs(storage control): retain jsdocs for overloads and only generate docs for uber stor…#7023
ddelgrosso1 merged 2 commits intomainfrom
fix-storage-control-docs

Conversation

@ddelgrosso1
Copy link
Contributor

…age control client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner January 21, 2026 17:04
@ddelgrosso1 ddelgrosso1 changed the title fix: retain jsdocs for overloads and only generate docs for uber stor… fix(storage control): retain jsdocs for overloads and only generate docs for uber stor… Jan 21, 2026
@ddelgrosso1 ddelgrosso1 force-pushed the fix-storage-control-docs branch from e456ce4 to f89fde0 Compare January 21, 2026 17:19
Copy link
Contributor

@sofisl sofisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think should be docs or build vs. fix?

@ddelgrosso1
Copy link
Contributor Author

LGTM but I think should be docs or build vs. fix?

Yea, now that I think about it I think docs should be sufficient.

@ddelgrosso1 ddelgrosso1 changed the title fix(storage control): retain jsdocs for overloads and only generate docs for uber stor… docs(storage control): retain jsdocs for overloads and only generate docs for uber stor… Jan 28, 2026
@ddelgrosso1 ddelgrosso1 force-pushed the fix-storage-control-docs branch from f89fde0 to 1914426 Compare January 28, 2026 18:52
@ddelgrosso1 ddelgrosso1 merged commit 588df78 into main Jan 28, 2026
10 of 12 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix-storage-control-docs branch January 28, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants