Skip to content

Comments

chore: squelch additional deprecated warnings#15985

Merged
scotthart merged 1 commit intogoogleapis:mainfrom
scotthart:v3_squelch_deprecated_warnings
Feb 19, 2026
Merged

chore: squelch additional deprecated warnings#15985
scotthart merged 1 commit intogoogleapis:mainfrom
scotthart:v3_squelch_deprecated_warnings

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 18, 2026

These were missed in prior PRs.


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner February 18, 2026 23:45
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses lingering deprecation warnings in two specific test files, cbt_test_proxy.cc and transaction_test.cc. By strategically including diagnostic control headers, the changes ensure that these warnings are suppressed during compilation, contributing to a cleaner build output and aligning with previous efforts to manage deprecation notices.

Highlights

  • Deprecation Warning Suppression: Implemented includes for "disable_deprecation_warnings.inc" and "diagnostics_pop.inc" in cbt_test_proxy.cc and transaction_test.cc to suppress previously missed deprecation warnings.
Changelog
  • google/cloud/bigtable/test_proxy/cbt_test_proxy.cc
    • Included google/cloud/internal/disable_deprecation_warnings.inc at the top of the file.
    • Included google/cloud/internal/diagnostics_pop.inc at the end of the file.
  • google/cloud/spanner/transaction_test.cc
    • Included google/cloud/internal/disable_deprecation_warnings.inc at the top of the file.
    • Included google/cloud/internal/diagnostics_pop.inc at the end of the file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds includes to suppress deprecation warnings in cbt_test_proxy.cc and transaction_test.cc. These changes are correct and help reduce compiler noise. The changes look good to me.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.63%. Comparing base (44f0334) to head (40dd560).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15985      +/-   ##
==========================================
- Coverage   92.64%   92.63%   -0.01%     
==========================================
  Files        2334     2334              
  Lines      214633   214633              
==========================================
- Hits       198840   198832       -8     
- Misses      15793    15801       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit f33848b into googleapis:main Feb 19, 2026
53 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants