ci: update cloudbuild configuration post v3 merge#15984
ci: update cloudbuild configuration post v3 merge#15984scotthart merged 3 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the continuous integration process by updating the build environments in Dockerfiles to use more controlled, source-built dependencies for critical libraries. Concurrently, it reconfigures all CI/CD triggers to align with the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates dependencies in the demo Dockerfiles, shifting from distribution-provided packages to building them from source to ensure specific versions are used. This includes Abseil, Protobuf, gRPC, and others. It also introduces a new CMake option GOOGLE_CLOUD_CPP_ENABLE_CTYPE_CORD_WORKAROUND to handle compatibility with different Protobuf versions regarding ctype=CORD. Additionally, a large number of CI trigger files have been updated to target the main branch and have their names simplified. My review focuses on inconsistencies in the Dockerfile configurations and formatting issues in the documentation and Dockerfiles.
c8d9d08 to
4eb70da
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15984 +/- ##
==========================================
- Coverage 92.64% 92.63% -0.01%
==========================================
Files 2334 2334
Lines 214633 214633
==========================================
- Hits 198838 198832 -6
- Misses 15795 15801 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4eb70da to
ff17fe5
Compare
ff17fe5 to
2f8a713
Compare
This change is