fix(docs): add docs.metadata.json for product neutral guides#15960
fix(docs): add docs.metadata.json for product neutral guides#15960
Conversation
Summary of ChangesHello @bshaffer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation build and publishing pipeline by integrating product-neutral guides. It ensures that these guides are properly processed, have their necessary metadata generated, and are included in the final documentation output, streamlining the overall documentation workflow. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the necessary infrastructure to generate and publish documentation for product-neutral guides. The changes correctly modify the publishing script to handle the new 'guides' documentation type and add a docs.metadata.json file required by the publishing process. My review includes one suggestion to improve the maintainability of the CMake script by using configure_file instead of an embedded string with add_custom_command, which is a more idiomatic approach for file generation from a template.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15960 +/- ##
==========================================
- Coverage 92.95% 92.95% -0.01%
==========================================
Files 2460 2460
Lines 228901 228901
==========================================
- Hits 212785 212779 -6
- Misses 16116 16122 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change is