-
Notifications
You must be signed in to change notification settings - Fork 436
feat(spanner): enable UUID data type #15867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces full support for the UUID data type within the Spanner client library. It extends the core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the UUID data type in Spanner. The changes include:
- Adding the
Uuidclass andMakeUuidfactory function. - Integrating the
Uuidtype into thespanner::Valueclass, with corresponding implementations for proto conversion and value retrieval. - Adding unit tests for
Uuidinvalue_test.ccand an integration test indata_types_integration_test.cc. - Updating the test database schema to include
UUIDandARRAY<UUID>columns.
The changes are well-implemented and the test coverage is good. I have one minor suggestion to improve consistency in error handling within the Value class. Overall, this is a solid contribution.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15867 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 2458 2458
Lines 227590 227658 +68
=======================================
+ Hits 211527 211607 +80
+ Misses 16063 16051 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.