Skip to content

Conversation

@scotthart
Copy link
Member

No description provided.

@scotthart scotthart requested a review from a team as a code owner January 8, 2026 23:44
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 8, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces full support for the UUID data type within the Spanner client library. It extends the core Value class to correctly handle UUID objects, enabling their proper conversion to and from protobuf representations. The changes also include updates to the test infrastructure and a suite of new tests to ensure the robust and accurate handling of UUIDs, both as single values and within arrays, during read and write operations.

Highlights

  • UUID Data Type Support: The Spanner client library now fully supports the UUID data type, allowing users to store and retrieve UUID values in their Spanner databases.
  • Value Class Integration: The core Value class has been extended to seamlessly handle UUID objects, including their conversion to and from protobuf representations for serialization and deserialization.
  • Comprehensive Testing: New unit and integration tests have been added to validate the correct behavior of UUIDs across various scenarios, such as basic semantics, protobuf conversion, error handling, and array support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the UUID data type in Spanner. The changes include:

  • Adding the Uuid class and MakeUuid factory function.
  • Integrating the Uuid type into the spanner::Value class, with corresponding implementations for proto conversion and value retrieval.
  • Adding unit tests for Uuid in value_test.cc and an integration test in data_types_integration_test.cc.
  • Updating the test database schema to include UUID and ARRAY<UUID> columns.

The changes are well-implemented and the test coverage is good. I have one minor suggestion to improve consistency in error handling within the Value class. Overall, this is a solid contribution.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (1986715) to head (4bbfbfe).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/spanner/value.cc 88.23% 2 Missing ⚠️
...r/integration_tests/data_types_integration_test.cc 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15867   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files        2458     2458           
  Lines      227590   227658   +68     
=======================================
+ Hits       211527   211607   +80     
+ Misses      16063    16051   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 50d4d5e into googleapis:main Jan 9, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants