-
Notifications
You must be signed in to change notification settings - Fork 77
chore: replace isort and black with ruff #2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Python code quality tooling by migrating from a combination of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively replaces isort and black with ruff for code formatting and import sorting across various noxfile.py configurations. The changes are logical, and I appreciate the effort to maintain backward compatibility by deprecating the blacken session with a clear warning. My review focuses on improving maintainability by ensuring the newly introduced RUFF_VERSION constant is used consistently across all session.install calls.
b0f881d to
2959030
Compare
4bb97c2 to
4e9959f
Compare
| ] | ||
| update_service_yaml = _add_python_settings(tmp_dir, python_settings) | ||
| session.run("python", "-c" f"{update_service_yaml}") | ||
| session.run("python", f"-c{update_service_yaml}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right? It seems like there's no space between the -c and the update_service_yaml
4e9959f to
eec3a67
Compare
679c9d7 to
4e80067
Compare
No description provided.