chore(EventBuilder): update character limits for session_id, session_number #2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jradcliff
reviewed
Oct 3, 2025
src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.spec.ts
Outdated
Show resolved
Hide resolved
ikuleshov
previously approved these changes
Oct 7, 2025
jradcliff
approved these changes
Oct 8, 2025
ikuleshov
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude
session_idandsession_numberevent parameter values from the 100-character length limit during schema validation. Update: Based on this discussion #2262 (comment), this PR removes the character limit check on the parameter value entirely.This fix is applied to the schemas for both recommended and custom events.
Note: Below validation message is expected at the moment.session_id and session_number character limit removed
Other parameters still have character limit enforced