Skip to content

No public description #14441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No public description #14441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions infra/base-images/base-builder/indexer/manifest_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ class BinaryConfig:

binary_name: str

@property
def uses_stdin(self) -> bool:
"""Whether the binary uses stdin."""
del self
return False

@classmethod
def from_dict(cls, config_dict: Mapping[str, Any]) -> Self:
"""Deserializes the correct `BinaryConfig` subclass from a dict."""
Expand Down Expand Up @@ -188,6 +194,11 @@ class CommandLineBinaryConfig(BinaryConfig):
# some targets like V8 require this to be false, see b/433718862.
filter_compile_commands: bool = True

@property
def uses_stdin(self) -> bool:
"""Whether the binary uses stdin."""
return manifest_constants.INPUT_FILE not in self.binary_args

@classmethod
def from_dict(cls, config_dict: Mapping[str, Any]) -> Self:
"""Deserializes the `CommandLineBinaryConfig` from a dict."""
Expand Down
Loading