Migrate from variableType(Matcher) to variableType(TypePredicate)#5593
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 13, 2026
Merged
Migrate from variableType(Matcher) to variableType(TypePredicate)#5593copybara-service[bot] merged 1 commit intomasterfrom
variableType(Matcher) to variableType(TypePredicate)#5593copybara-service[bot] merged 1 commit intomasterfrom
Conversation
`Matchers.variableType(Matcher)` uses `VariableTree#getType` to match variable types, which own't work for lambda parameters after the change. `Matchers.variableType(TypePredicate)` tests the inferred type of the variable, instead of going through the AST node for the type. PiperOrigin-RevId: 883260142
copybara-service
bot
force-pushed
the
test_883105208
branch
from
60334fa to
230fe2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from
variableType(Matcher)tovariableType(TypePredicate)Matchers.variableType(Matcher)usesVariableTree#getTypeto match variable types, which own't work for lambda parameters after the change.Matchers.variableType(TypePredicate)tests the inferred type of the variable, instead of going through the AST node for the type.