integration: adjust tests for containerd snapshotters#3766
integration: adjust tests for containerd snapshotters#3766thaJeztah wants to merge 2 commits intogoogle:masterfrom
Conversation
|
haven't tested locally, so (ab)using CI to see if it passes, but looks like it needs approval again @dims 🙈 (is there some way around that, or is it for all contributors ?) |
|
i am here for you @thaJeztah :) (not a GOOG employee, so am a guest here! can't fiddle with things) |
|
@thaJeztah for now please rebase your other PR, we pinned the SHA of the image: |
|
Thank you! Yes, these are a bit of a nuisance; debugging CI usually is a bit of trial-and-error, and I'm not very familiar with the codebase, so that makes it extra fun. OK got some other failures. Maybe I should look if I can run these tests locally somewhere; of course don't let me stop others from digging in as well! (for anyone stumbling on this PR).
oh, thanks, will do! |
1edba6b to
980f0b8
Compare
|
@thaJeztah can you please revert the change we made here: and see if this still works? |
Attempt to adjust the tests to work with a docker daemon using the containerd snapshotters (which would have, e.g., "overlayfs" instead of "overlay2" as storage driver). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ging-test-infra/bootstrap" This reverts commit a310a2c. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
980f0b8 to
ccdb82b
Compare
|
done! added a commit to revert it; let's see what breaks 😅 (ISTR things weren't happy before that, so possibly more changes are needed) |
|
interesting failure |
|
Wondering if it's related to; |
relates to #3761 (comment)
Attempt to adjust the tests to work with a docker daemon using the containerd snapshotters (which would have, e.g., "overlayfs" instead of "overlay2" as storage driver).