fix: suppress UserWarning when logging function_call responses#4689
fix: suppress UserWarning when logging function_call responses#4689OiPunk wants to merge 1 commit intogoogle:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of UserWarning messages being logged excessively when function_call responses are encountered. The introduction of the _get_text_from_response helper function provides a clean and robust way to extract text content without triggering these warnings. The accompanying unit tests are comprehensive, covering various scenarios including text-only, function-call-only, mixed content, and edge cases like empty candidates or None content, ensuring the fix is reliable and prevents regressions. The solution is well-implemented and directly resolves the reported problem.
_build_response_log() accessed resp.text on responses containing function_call parts, triggering a UserWarning from google.genai on every tool invocation. Extract text from parts directly via a new _get_text_from_response() helper to avoid the warning. Fixes google#4685
52a649b to
b448fed
Compare
Summary
Fixes #4685
_build_response_log()accessesresp.textwhich triggers aUserWarningfromgoogle.genaiwhenever the response contains non-text parts (e.g.function_call)Changes
_get_text_from_response()helper that extracts text fromresponse.candidates[0].content.partsdirectly, bypassing the.textproperty that emits the warning_build_response_log()to use the new helperTest plan
test_text_only_response— verifies text extraction for normal responsestest_function_call_response_no_warning— verifies no warning on function-call-only responsestest_mixed_parts_no_warning— verifies text extraction from mixed text+function_call responsestest_empty_candidates/test_none_content— edge casestest_function_call_log_no_warning— regression test for Adk Function Call Warning #4685🤖 Generated with Claude Code