Fix alignment on RID and other classes that use uint8_t opaque[SIZE]#1958
Open
dsnopek wants to merge 1 commit intogodotengine:masterfrom
Open
Fix alignment on RID and other classes that use uint8_t opaque[SIZE]#1958dsnopek wants to merge 1 commit intogodotengine:masterfrom
RID and other classes that use uint8_t opaque[SIZE]#1958dsnopek wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1956
Unfortunately, we don't actually have alignment information in
extension_api.json, so this code has to "guess" (although, as far as I can tell the logic in here should be correct for all existing Godot builtin types).On 64-bit builds, it appears that all of them have 8-byte alignment, but on 32-bit builds, a handful of them appear to have 4-byte alignment.
Ideally, it would be nice for the alignment to be part of the
extension_api.jsonand for us to not change in Godot 4.x ever. An alternative would have been to standardize on an alignment of 8 for everything, but we can't do that because of the situation on 32-bit builds.This is something we should probably discuss further with the whole GDExtension team