fix: correct the value of ROOT_TASKFILE when no entrypoint#2635
Merged
vmaerten merged 2 commits intogo-task:mainfrom Jan 25, 2026
Merged
fix: correct the value of ROOT_TASKFILE when no entrypoint#2635vmaerten merged 2 commits intogo-task:mainfrom
vmaerten merged 2 commits intogo-task:mainfrom
Conversation
…t the correct taskfile path is used.
vmaerten
approved these changes
Jan 25, 2026
Member
vmaerten
left a comment
There was a problem hiding this comment.
Way better than my previous solution!
Thanks!
I've just added a test
vmaerten
added a commit
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When task starts wthout a taskfile specified the entrypoint will be either the parameter
--taskfile, which may be a directory, or the current directory. In such cases task will search for the taskfile to use. When that taskfile is found, thee.Entrypointneeds to be updated to reflect the resolved entrypoint.Remarkably, this was not just broken, but really broken:
even more remarkable, fixing the issue does not break any tests. The corrected output:
The following taskfile used:
fixes #1706
closes #1708