Refactor compare router param parse and fix bugs #36105
Open
+546
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
Co-authored-by: techknowlogick <[email protected]> Signed-off-by: Lunny Xiao <[email protected]>
Member
|
please have a look at #36116 |
lunny
changed the title
Member
Author
This has been included and it's ready to review now. |
Zettat123
approved these changes
Dec 11, 2025
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/need 1
GiteaBot
removed
the
lgtm/need 1
Member
Author
This will be partially backport. Only bugfixes will be backport. |
lunny
added
backport/done
silverwind
reviewed
Dec 12, 2025
silverwind
reviewed
Dec 12, 2025
…lunny/refactor_compare
silverwind
approved these changes
Dec 13, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Dec 13, 2025
wxiaoguang
reviewed
Dec 15, 2025
Signed-off-by: wxiaoguang <[email protected]>
wxiaoguang
reviewed
Dec 15, 2025
Comment on lines
+87
to
+89
| if routerParam == "" { | ||
| return &CompareRouterReq{}, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Is it valid argument?
What will &CompareRouterReq{} compare?
wxiaoguang
reviewed
Dec 15, 2025
|
|
||
| ci.BaseBranch = util.Iif(compareReq.BaseOriRef == "", baseRepo.DefaultBranch, compareReq.BaseOriRef) | ||
| ci.HeadBranch = util.Iif(compareReq.HeadOriRef == "", ci.HeadRepo.DefaultBranch, compareReq.HeadOriRef) | ||
| ci.DirectComparison = compareReq.DirectComparison() |
Contributor
There was a problem hiding this comment.
Why not just use ci (parse the route parameter into CompareInfo) ? What's the purpose of passing compareReq into ci?
Member
Author
There was a problem hiding this comment.
It's easier to write the unit test for the router param parsing.
Contributor
There was a problem hiding this comment.
Don't see why it is "easier"
Now you have 3 different structs for the same purpose:
- CompareRouterReq
- parseCompareInfoResult
- CompareInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36116
Fix #35912
Fix #20906