refactor(oauth): extract shared constants and types#13
Merged
Conversation
…tion - Replace inline OAuth error code strings with named constants per RFC 8628 - Replace hardcoded endpoint URL paths with named constants - Unify duplicate anonymous token response structs into shared tokenResponse type - Cap TUI status log to 50 entries to prevent unbounded memory growth Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Pull request overview
Refactors the OAuth device-flow CLI to centralize shared OAuth constants/types and to prevent unbounded growth of the TUI status log.
Changes:
- Introduces named constants for OAuth endpoint paths and common OAuth error codes.
- Unifies duplicate token endpoint JSON response structs into a shared
tokenResponsetype. - Caps the TUI status log to the most recent 50 entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tui/model.go |
Adds a maxStatusLines limit and truncation logic to bound the status log size. |
main.go |
Extracts OAuth endpoint paths + error codes into constants and consolidates token response parsing into tokenResponse. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Separate RFC 8628 device authorization error codes from RFC 6749 token endpoint error codes to avoid misleading readers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenResponsetypeTest plan
go build ./...passesgo test ./...passes (22s)golangci-lint runreports 0 issues🤖 Generated with Claude Code