Add enum name to default case deserialization exception for C++#2797
Open
cconverse711 wants to merge 1 commit intoglideapps:masterfrom
Open
Add enum name to default case deserialization exception for C++#2797cconverse711 wants to merge 1 commit intoglideapps:masterfrom
cconverse711 wants to merge 1 commit intoglideapps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes enumeration name in std::runtime_error message for enum deserialization failure.
Related Issue
#2796
Motivation and Context
#2796
Previous Behaviour / Output
std::runtime_error is raised with message
Input JSON does not conform to schema!New Behaviour / Output
std::runtime_error raised with message like
Cannot deserialize to enumeration "FooBar".How Has This Been Tested?
Existing C++ unit tests
Screenshots (if appropriate):