Fix graph viewer not re-rendering correctly after loading a second graph#4304
Merged
d10c merged 1 commit intogithub:mainfrom Feb 18, 2026
Merged
Fix graph viewer not re-rendering correctly after loading a second graph#4304d10c merged 1 commit intogithub:mainfrom
d10c merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the graph viewer (CFG viewer) where the component wasn't properly re-rendering after loading a second graph without closing the webview. The issue manifested as broken pan-to-scroll functionality and incorrect scroll position behavior after viewing a second CFG.
Changes:
- Updated the React key calculation for the ResultTables component to include the
resultsPathin addition toselectedTableandpageNumber
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d10c
reviewed
Feb 18, 2026
Contributor
d10c
left a comment
There was a problem hiding this comment.
Thanks! Have you tested that this works now?
Contributor
Author
|
Yes, I've tested it on my own machine. |
d10c
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the graph viewer (CFG viewer) that appears after loading two CFGs without closing the webview in-between.
To reproduce the issue:
Copilot CLI duly noticed that the
keyfor theResultsAppcomponent was not changing when loading a new query run. Changing the key ensures the underlyingd3-graphvizcomponent gets reset properly when rendering a new graph.