Skip to content

Conversation

@Rifat-Hasan-BD
Copy link
Contributor

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Add better meaning in subscribe heading
@Rifat-Hasan-BD Rifat-Hasan-BD changed the title Initial pull request for Bangla translation 2nd try Initial pull request for Bangla translation Nov 29, 2024
@Rifat-Hasan-BD
Copy link
Contributor Author

I have no idea why 1 test are keep failing all the time. Should i still work on the translation?

@Ashrafjafr

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Contributor Author

[email protected]

What do you mean by the mail address?

@Rifat-Hasan-BD
Copy link
Contributor Author

@jmeridth As per your request i start translating everything into Bangla language. But i'm unable contact with any maintainer. It's my first contribution to a open source project. Should i continue the translation?

@Rifat-Hasan-BD
Copy link
Contributor Author

@ahpook should i continue translation?

@Dirtywaters6801

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Contributor Author

@Dirtywaters6801 in which article or section line 745 doesn't end with signature? I can't find it. Can explain it little more?

@Dirtywaters6801

This comment was marked as spam.

@Rifat-Hasan-BD
Copy link
Contributor Author

@Dirtywaters6801 How can i fix it? I have no idea. Can you help me?

@Ashrafjafr

This comment was marked as spam.

@jmeridth
Copy link
Contributor

jmeridth commented Dec 2, 2024

[email protected]

What do you mean by the mail address?

I've marked as spam. Author can respond but usually that is spam.

@jmeridth
Copy link
Contributor

jmeridth commented Dec 2, 2024

@jmeridth As per your request i start translating everything into Bangla language. But i'm unable contact with any maintainer. It's my first contribution to a open source project. Should i continue the translation?

Yes. Please continue. Your failing tests can be seen here and reasons are listed. Looks like mainly complaining about unordered lists formatting. I'll look into the 404/403s before the html proofer.

Thank you for your contribution.

looks like most of the other comments on this PR are spam. I'm marking them accordingly.

@tomthorogood
Copy link
Contributor

@Rifat-Hasan-BD There is one link you have included that is still a 404. Once that is fixed we can accept your translation. 🫶

From the test error messages:

* At _site/bn/getting-paid/index.html:530:

  External link https://paypal.github.io/ failed (status code 404)

I tried and this link indeed does not work.

@jmeridth
Copy link
Contributor

@Rifat-Hasan-BD I removed the paypal.github.io link in all translations in main branch with #3352. You can do the same in your translation.

paypal.github.io no longer exists
@jmeridth jmeridth added this pull request to the merge queue Jan 22, 2025
Merged via the queue into github:main with commit 8d0a342 Jan 22, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants