Skip to content

Use typed IconTheme constants from Go SDK #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 2 commits into from
Dec 22, 2025
Merged

Use typed IconTheme constants from Go SDK #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3769712
Initial plan
Copilot Dec 22, 2025
61913bb
Use typed IconTheme constants from Go SDK
Copilot Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/octicons/octicons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ func Icons(name string) []mcp.Icon {
{
Source: DataURI(name, ThemeLight),
MIMEType: "image/png",
Theme: string(ThemeLight),
Theme: mcp.IconThemeLight,
},
{
Source: DataURI(name, ThemeDark),
MIMEType: "image/png",
Theme: string(ThemeDark),
Theme: mcp.IconThemeDark,
},
}
}
5 changes: 3 additions & 2 deletions pkg/octicons/octicons_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"strings"
"testing"

"github.com/modelcontextprotocol/go-sdk/mcp"
"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -87,13 +88,13 @@ func TestIcons(t *testing.T) {
assert.Equal(t, DataURI(tc.icon, ThemeLight), result[0].Source)
assert.Equal(t, "image/png", result[0].MIMEType)
assert.Empty(t, result[0].Sizes) // Sizes field omitted for backward compatibility
assert.Equal(t, "light", result[0].Theme)
assert.Equal(t, mcp.IconThemeLight, result[0].Theme)

// Verify second icon is dark theme
assert.Equal(t, DataURI(tc.icon, ThemeDark), result[1].Source)
assert.Equal(t, "image/png", result[1].MIMEType)
assert.Empty(t, result[1].Sizes) // Sizes field omitted for backward compatibility
assert.Equal(t, "dark", result[1].Theme)
assert.Equal(t, mcp.IconThemeDark, result[1].Theme)
})
}
}
Expand Down