Java: Add support for "View CFG" in VSCode.#21268
Open
aschackmull wants to merge 3 commits intogithub:mainfrom
Open
Java: Add support for "View CFG" in VSCode.#21268aschackmull wants to merge 3 commits intogithub:mainfrom
aschackmull wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the control flow graph (CFG) printing implementation from the language-agnostic Cfg.qll file into a dedicated PrintGraph.qll module and adds support for the "View CFG" query in VSCode for Java.
Changes:
- Created a new shared
PrintGraph.qllmodule with reusable logic for printing CFGs in tests, Mermaid diagrams, and VSCode - Refactored
Cfg.qllto use the newPrintGraphmodule instead of inline implementations - Added Java-specific implementation in
ControlFlowGraph.qlland createdprintCfg.qlquery file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/controlflow/codeql/controlflow/PrintGraph.qll | New shared module containing extracted logic for printing CFGs with support for test output, Mermaid diagrams, and VSCode's "View CFG" feature |
| shared/controlflow/codeql/controlflow/Cfg.qll | Refactored to import and use the new PrintGraph module instead of inline implementations |
| java/ql/lib/semmle/code/java/ControlFlowGraph.qll | Implements PrintGraphInput signature to enable CFG printing for Java |
| java/ql/lib/printCfg.ql | New query file implementing "View CFG" for Java, following the pattern from C#, Ruby, Rust, and Swift |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the "View CFG" implementation from
Cfg.qllto its own file and implements it for Java.