Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds explicit permission declarations to GitHub Actions workflow files to follow security best practices by limiting workflow permissions to only what's needed. This implements the principle of least privilege for GitHub Actions workflows.
Key Changes
- Added
permissionsblocks to 18 workflow files with appropriate access levels - Most read-only workflows receive
contents: readpermission - Workflows that modify repository state receive elevated permissions like
contents: write,pull-requests: write, oractions: write
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/verify-standard-library-dependencies.yml |
Added read-only permissions for verification workflow |
.github/workflows/validate-release.yml |
Added read/write permissions for validation workflow that needs to write checks and PR comments |
.github/workflows/validate-query-test-case-formatting.yml |
Added read-only permissions for formatting validation |
.github/workflows/validate-query-help.yml |
Added read-only permissions for help file validation |
.github/workflows/validate-query-formatting.yml |
Added read-only permissions for query formatting validation |
.github/workflows/validate-package-files.yml |
Added read-only permissions for package validation |
.github/workflows/upgrade_codeql_dependencies.yml |
Added write permissions for workflow that creates PRs |
.github/workflows/update-release.yml |
Added write permissions for release update workflow |
.github/workflows/update-check-run.yml |
Added read-only permissions for check run updates |
.github/workflows/tooling-unit-tests.yml |
Added read-only permissions for unit testing |
.github/workflows/standard_library_upgrade_tests.yml |
Added read-only permissions with typo in permission key |
.github/workflows/generate-html-docs.yml |
Added read-only permissions for documentation generation |
.github/workflows/finalize-release.yml |
Added write permissions for release finalization |
.github/workflows/extra-rule-validation.yml |
Added read-only permissions for rule validation |
.github/workflows/dispatch-release-performance-check.yml |
Added mixed permissions for performance check dispatch |
.github/workflows/dispatch-matrix-test-on-comment.yml |
Added mixed permissions for matrix test dispatch |
.github/workflows/codeql_unit_tests.yml |
Added read-only permissions for CodeQL testing |
.github/workflows/code-scanning-pack-gen.yml |
Added read-only permissions for pack generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.