Fix permissions for update-release* workflows#1009
Merged
knewbury01 merged 2 commits intomainfrom Dec 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes GitHub Actions workflow configurations for release management by moving permissions from workflow-level to job-level, updating action versions from v5 to v6, and improving workflow structure. This change enhances security by applying the principle of least privilege at the job level.
- Relocated permissions from workflow-level to job-level for better security granularity
- Updated
actions/checkoutandactions/setup-pythonfrom v5 to v6 - Added formatting improvements (blank lines) for better readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/update-release.yml |
Moved permissions from workflow-level (lines 2-5) to job-level (lines 26-29), updated actions/checkout and actions/setup-python to v6 |
.github/workflows/update-release-status.yml |
Moved permissions from workflow-level to job-level for both the validate-check-runs job (lines 21-24) and the update-release job (lines 135-138), updated actions/checkout to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the GitHub Actions workflows related to release management. The main focus is on improving permissions handling by moving permissions from the workflow level to the job level, updating action versions, and ensuring permissions are properly set for each job. These changes enhance workflow security and maintain compatibility with the latest action versions.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.