Skip to content

feat: add minimumVersion values for language overlay flags#3550

Open
sam-robson wants to merge 2 commits intomainfrom
sam-robson/overlay-per-lang-min-bundle-version
Open

feat: add minimumVersion values for language overlay flags#3550
sam-robson wants to merge 2 commits intomainfrom
sam-robson/overlay-per-lang-min-bundle-version

Conversation

@sam-robson
Copy link
Contributor

Add per-language minimumVersion values to the overlay analysis feature flags, so that each language's overlay feature is only enabled when the CLI version supports it.

Also remove feature flags for languages not yet GA or in staff-ship (actions, cpp, rust, swift)

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Copilot AI review requested due to automatic review settings March 5, 2026 17:11
@sam-robson sam-robson requested a review from a team as a code owner March 5, 2026 17:11
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I checked the version numbers and they all look good. Consider adding a unit test that when a language isn't in OVERLAY_ANALYSIS_CODE_SCANNING_FEATURES overlay isn't enabled (see the existing tests in src/config-utils.test.ts). Otherwise this looks good to merge.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the size/M Should be of average difficulty to review label Mar 5, 2026
@sam-robson sam-robson force-pushed the sam-robson/overlay-per-lang-min-bundle-version branch from 187f9d3 to 9d0a2f2 Compare March 5, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Should be of average difficulty to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants