feat: add minimumVersion values for language overlay flags#3550
Open
sam-robson wants to merge 2 commits intomainfrom
Open
feat: add minimumVersion values for language overlay flags#3550sam-robson wants to merge 2 commits intomainfrom
sam-robson wants to merge 2 commits intomainfrom
Conversation
henrymercer
reviewed
Mar 5, 2026
Contributor
henrymercer
left a comment
There was a problem hiding this comment.
Nice! I checked the version numbers and they all look good. Consider adding a unit test that when a language isn't in OVERLAY_ANALYSIS_CODE_SCANNING_FEATURES overlay isn't enabled (see the existing tests in src/config-utils.test.ts). Otherwise this looks good to merge.
…anguage feature flags
187f9d3 to
9d0a2f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per-language
minimumVersionvalues to the overlay analysis feature flags, so that each language's overlay feature is only enabled when the CLI version supports it.Also remove feature flags for languages not yet GA or in staff-ship (
actions,cpp,rust,swift)Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist