[GHSA-h2f4-v4c4-6wx4] Uncontrolled Resource Consumption in org.eclipse.jetty:jetty-server#7093
Open
Meet003118 wants to merge 1 commit intoMeet003118/advisory-improvement-7093from
Open
Conversation
|
🤔 We seem to have taken the fixed versions from this comment. jetty/jetty.project#2722 (which jetty/jetty.project#2723 fixes) says it is addressing CVE-2019-9515, though the vulnerabilities seem related. I will take a closer look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Two updates are made:
The CVE describes two attack vectors - a single large SETTINGS frame with many keys, and many small SETTINGS frames.
The fix can be traced to commit: jetty/jetty.project@9eca404 and PR: jetty/jetty.project#2723 - Improve configurability for SETTINGS frames, which :
SettingsFrame.javakeyscounter inSettingsBodyParser.javathat is NOT reset between frames (covering both attack vectors)testGenerateParseTooManySettingsInOneFrameandtestGenerateParseTooManySettingsInMultipleFramesthat directly validate both CVE attack scenariosThis was also independently confirmed in a bugzilla report : https://bugzilla.redhat.com/show_bug.cgi?id=1696062#c3
Commit 9eca404 was only merged into the 9.4.x branch and shipped in version 9.4.12.RC1. It was never backported to 9.3.x. This can be verified by inspecting
SettingsBodyParser.javadirectly on the 9.3.x branch - themaxKeysguard andDEFAULT_MAX_KEYSconstant are both absent across all 9.3.x versions including 9.3.25.v20180904.The 9.3.x patched version stated in the advisory is therefore incorrect.
The vulnerable and patched code resides in
org.eclipse.jetty.http2:http2-common(SettingsBodyParser.java), not in GA :org.eclipse.jetty:jetty-server, jetty-server contains no HTTP/2 frame parsing logic.