fix: move workflow permissions from job level to workflow level#507
Closed
fix: move workflow permissions from job level to workflow level#507
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves GitHub Actions token permissions declarations from individual job blocks to the workflow level to avoid unintended permission capping that can break write operations.
Changes:
- Hoists job-level
permissionsup to workflow-level across multiple workflows. - Expands workflow-level permissions in multi-job workflows to the union required by all jobs (notably
release.yml). - Aligns workflows like
mark-ready-when-readywith the permissions required for PR updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/scorecard.yml | Moves id-token/security-events permissions to workflow scope. |
| .github/workflows/release.yml | Sets workflow-level permissions to cover all reusable-workflow jobs. |
| .github/workflows/pr-title.yml | Moves job permissions to workflow scope for reusable workflow invocation. |
| .github/workflows/mark-ready-when-ready.yml | Elevates workflow permissions to support PR-ready transitions. |
| .github/workflows/codeql.yml | Moves job permissions to workflow scope for CodeQL analysis. |
| .github/workflows/auto-labeler.yml | Moves job permissions to workflow scope for label automation. |
Comment on lines
8
to
+14
| permissions: | ||
| contents: read | ||
| attestations: write | ||
| contents: write | ||
| discussions: write | ||
| id-token: write | ||
| packages: write | ||
| pull-requests: read |
Job-level permissions are capped by workflow-level permissions. With workflow-level set to only `contents: read`, job-level write permissions were silently capped, breaking actions like markPullRequestReadyForReview.
jmeridth
force-pushed
the
fix/workflow-permissions-to-workflow-level
branch
from
87a60d8 to
12e4bee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves permissions declarations from job level back to workflow level across all workflow files.
Why
Workflow-level
permissionssets the maximum token permissions for all jobs. Withcontents: readat workflow level, job-levelcontents: writewas silently capped, causingResource not accessible by integrationerrors (e.g.,markPullRequestReadyForReviewin mark-ready-when-ready).Notes