Skip to content

fix(a11y): align submenu arrow keys and Escape behavior with ARIA#2426

Merged
ghiscoding merged 1 commit intomasterfrom
bugfix/left-sub-menu-a11y
Mar 5, 2026
Merged

fix(a11y): align submenu arrow keys and Escape behavior with ARIA#2426
ghiscoding merged 1 commit intomasterfrom
bugfix/left-sub-menu-a11y

Conversation

@ghiscoding
Copy link
Owner

fixes an issue with sub-menu that didn't open when sub-menu is expected to open on the left (e.g. if we open our menu from the right far side of the grid) and we use the arrow right key, it should always open sub-menu with arrow right (even if menu opens on the left side). Also left arrow key is always considered as a key to close current sub-menu.

This follows ARIA patterns described in this article:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/menu_role

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (a77150e) to head (ff4ac92).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2426   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         196      196           
  Lines       24318    24318           
  Branches     8518     8519    +1     
=======================================
  Hits        24318    24318           
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2426

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2426

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2426

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2426

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2426

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2426

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2426

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2426

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2426

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2426

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2426

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2426

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2426

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2426

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2426

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2426

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2426

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2426

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2426

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2426

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2426

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2426

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2426

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2426

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2426

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2426

commit: e5ce2f3

@ghiscoding ghiscoding merged commit d99675e into master Mar 5, 2026
12 checks passed
@ghiscoding ghiscoding deleted the bugfix/left-sub-menu-a11y branch March 5, 2026 18:00
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

🎉 This pull request is included in version 10.1.0 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant