CLI: fixed adding cli and completion into docker containers, improved docs #18003
+23
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Honestly, since I don't know if nix/rpm stuff is still usable (I don't think we have any maintainers who know anything about those any more) I didn't want to touch them. |
Author
|
Ok, then I am going to revert the change to the |
andrew-aladev
force-pushed
the
feature/fix-devops-cli-and-completion-and-related-docs
branch
from
e67fdd7 to
e52c4a4
Compare
CISC
reviewed
Dec 13, 2025
andrew-aladev
force-pushed
the
feature/fix-devops-cli-and-completion-and-related-docs
branch
from
e52c4a4 to
6fc076e
Compare
CISC
reviewed
Dec 13, 2025
andrew-aladev
force-pushed
the
feature/fix-devops-cli-and-completion-and-related-docs
branch
from
6fc076e to
99ead70
Compare
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @CISC I've read your PR #17964 and caught the idea: you've added both
cliandcompletioninto:lightimage. This is a good decision; we just need to improve this idea a bit:completiontollama-cli-cann.Dockerfile,llama-cpp-cuda.srpm.spec, andllama-cpp.srpm.spec.main executableswith clear executable lists indocs/docker.md.cliandcompletionindocs/docker.md.Related PRs: #17964, #17824.
Please review; thank you.