CLI: fixed dead links to tools/main for cli and completion, fixed code owners #17993
+28
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-aladev
force-pushed
the
feature/fix-dead-links-to-tools-main-cli
branch
from
950f9d0 to
862d8cd
Compare
6 tasks
ngxson
approved these changes
Dec 13, 2025
| /tests/test-chat-.* @pwilkin | ||
| /tools/batched-bench/ @ggerganov | ||
| /tools/main/ @ggerganov | ||
| /tools/cli/ @ngxson |
Collaborator
There was a problem hiding this comment.
@ggerganov should you be added as codeowner of CLI, or it's fine as-is here?
Collaborator
There was a problem hiding this comment.
I think I'll merge this PR as-is and decide this later if needed
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start the separation of
cliandcompletiontools.tools/main.cliandcompletiontogether where the user can use both tools.cliandcompletiontools.README.mdtotools/cliwithTODO.llama-completioninstead ofllama-cliintools/completionREADME.PR is related to #17824.
I've received an email notification about @jsjtxietian and @bandoti mentioning dead links to CLI and completion. Please review this PR.
Thank you.