-
Notifications
You must be signed in to change notification settings - Fork 14.1k
server: add encoder-decoder model support (T5, BART, MADLAD) #17956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Turee
wants to merge
1
commit into
ggml-org:master
Choose a base branch
from
Turee:add-enc-dec-model-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for encoder-decoder models in llama-server, matching the behavior of llama-cli. This enables translation models like MADLAD and other T5-based models to work with the server. Changes: - Add has_encoder flag to detect encoder-decoder models at load time - Implement llama_encode() call for encoder-decoder prompt processing - Use decoder_start_token to initialize decoder after encoding - Clear decoder KV cache before each new request (no prefix caching) - Disable incompatible features for encoder-decoder models: - Context shift (encoder outputs are fixed) - Speculative decoding (not supported) - Warn about prompt caching differences - Add edge case handling for empty text tokens The encoder processes the full prompt, then the decoder generates output using cross-attention to the encoder's hidden states.
Author
|
Ran cpu only tests: 100% tests passed, 0 tests failed out of 38 Label Time Summary: |
Author
|
Performance seems unaffected |
Author
|
Perplexity before: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for encoder-decoder models in llama-server, matching the behavior of llama-cli. This enables translation models like MADLAD and other T5-based models to work with the server.
Changes:
The encoder processes the full prompt, then the decoder generates output using cross-attention to the encoder's hidden states.
Make sure to read the contributing guidelines before submitting a PR
Cursor /w Opus 4.5 was heavily utilized to develop this change.