-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(occurrences on eap): Implement EAP read for error counts in suspect tag calculation #104916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104916 +/- ##
===========================================
- Coverage 80.57% 80.49% -0.08%
===========================================
Files 9431 9416 -15
Lines 404261 403719 -542
Branches 25655 25756 +101
===========================================
- Hits 325718 324990 -728
- Misses 78075 78295 +220
+ Partials 468 434 -34 |
thetruecpaul
approved these changes
Dec 22, 2025
Contributor
thetruecpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an
EndpointTraceItemTableRPC query to fetch error counts from EAP, used in the calculation of suspect tags.Tested locally to ensure that the count aggregation is coming back correctly from EAP:
To roll this out, we can:
eap.occurrences.should_double_readoption on for the S4S region onlyeap.occurrences.validate_readsmetric start getting recorded and then converge to 0 mismatches over time (as EAP gets up-to-speed on all the groups within retention)