Lint rules and code style for expo sample app #5484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwx
changed the title
Contributor
|
@sentry review |
antonis
reviewed
Dec 18, 2025
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
1
to
5
| import * as Sentry from '@sentry/react-native'; | ||
| import { SeverityLevel } from '@sentry/core'; | ||
| import { SeverityLevel } from '@sentry/react-native'; | ||
|
|
||
| export const setScopeProperties = () => { | ||
| const dateString = new Date().toString(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| 0b64753+dirty | 448.67 ms | 474.61 ms | 25.94 ms |
| 1c38acd+dirty | 398.09 ms | 409.18 ms | 11.09 ms |
| 294387d+dirty | 424.30 ms | 465.40 ms | 41.10 ms |
| 8d0a325+dirty | 406.48 ms | 415.02 ms | 8.54 ms |
| 5ee3314+dirty | 415.80 ms | 426.14 ms | 10.34 ms |
| 5602cc4+dirty | 419.91 ms | 439.52 ms | 19.61 ms |
| 59f3a84+dirty | 382.16 ms | 376.45 ms | -5.71 ms |
| 46e3d54+dirty | 467.76 ms | 487.53 ms | 19.78 ms |
| ebf60f9+dirty | 378.38 ms | 405.48 ms | 27.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 0b64753+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 1c38acd+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 294387d+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 8d0a325+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 5ee3314+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 5602cc4+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 59f3a84+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 46e3d54+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| ebf60f9+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 170d5ea+dirty | 1233.96 ms | 1242.54 ms | 8.58 ms |
| 9f211e3+dirty | 1215.38 ms | 1218.15 ms | 2.77 ms |
| 8e653ac+dirty | 1215.46 ms | 1220.20 ms | 4.75 ms |
| c94a927+dirty | 1211.33 ms | 1223.31 ms | 11.97 ms |
| d081295+dirty | 1205.24 ms | 1207.52 ms | 2.28 ms |
| 69602ce+dirty | 1230.59 ms | 1230.84 ms | 0.24 ms |
| 0b64753+dirty | 1225.77 ms | 1232.98 ms | 7.21 ms |
| f234eb4+dirty | 1233.52 ms | 1235.78 ms | 2.26 ms |
| 20d5eaa+dirty | 1224.67 ms | 1223.16 ms | -1.51 ms |
| d1bfbde+dirty | 1221.30 ms | 1218.70 ms | -2.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 170d5ea+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 9f211e3+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 8e653ac+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| c94a927+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 69602ce+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 0b64753+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| f234eb4+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| 20d5eaa+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d1bfbde+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 170d5ea+dirty | 1219.27 ms | 1231.90 ms | 12.63 ms |
| 9f211e3+dirty | 1218.80 ms | 1233.88 ms | 15.08 ms |
| 8e653ac+dirty | 1218.63 ms | 1223.88 ms | 5.24 ms |
| c94a927+dirty | 1227.14 ms | 1239.64 ms | 12.50 ms |
| d081295+dirty | 1214.40 ms | 1211.27 ms | -3.13 ms |
| 69602ce+dirty | 1235.65 ms | 1230.82 ms | -4.83 ms |
| 0b64753+dirty | 1232.49 ms | 1226.96 ms | -5.53 ms |
| f234eb4+dirty | 1227.22 ms | 1228.45 ms | 1.22 ms |
| 20d5eaa+dirty | 1231.12 ms | 1226.00 ms | -5.12 ms |
| d1bfbde+dirty | 1216.83 ms | 1212.83 ms | -3.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 170d5ea+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 9f211e3+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 8e653ac+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| c94a927+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 69602ce+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 0b64753+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| f234eb4+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| 20d5eaa+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d1bfbde+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes #5436
Apparently only the expo app needed this update because lint rules were already specified for
samples/react-nativeandsamples/react-native-macos📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog