fix(metro): Add next parameter to metroMiddleware to satisfy HandleFunction type

packages/core/src/js/tools/metroMiddleware.ts

@@ -14,6 +14,7 @@ const readFileAsync = promisify(readFile);
 export const stackFramesContextMiddleware: Middleware = async (
   request: IncomingMessage,
   response: ServerResponse,
+  _next: () => void,
 ): Promise<void> => {
   debug.log('[@sentry/react-native/metro] Received request for stack frames context.');
   request.setEncoding('utf8');
@@ -89,11 +90,15 @@ const SENTRY_CONTEXT_REQUEST_PATH = `${SENTRY_MIDDLEWARE_PATH}/context`;
  * Creates a middleware that adds source context to the Sentry formatted stack frames.
  */
 export const createSentryMetroMiddleware = (middleware: Middleware): Middleware => {
-  return (request: IncomingMessage, response: ServerResponse, next: unknown) => {
+  return (request: IncomingMessage, response: ServerResponse, next: () => void) => {
     if (request.url?.startsWith(SENTRY_CONTEXT_REQUEST_PATH)) {
-      return stackFramesContextMiddleware(request, response);
+      return stackFramesContextMiddleware(request, response, next);
     }
-    return middleware(request, response, next);
+    return (middleware as (req: IncomingMessage, res: ServerResponse, next: () => void) => void)(
+      request,
+      response,
+      next,
+    );
   };
 };
 

packages/core/test/tools/metroMiddleware.test.ts

@@ -78,7 +78,7 @@ describe('metroMiddleware', () => {
       } as any;
       testedMiddleware(sentryRequest, response, next);
       expect(defaultMiddleware).not.toHaveBeenCalled();
-      expect(spiedStackFramesContextMiddleware).toHaveBeenCalledWith(sentryRequest, response);
+      expect(spiedStackFramesContextMiddleware).toHaveBeenCalledWith(sentryRequest, response, next);
     });
 
     it('should call default middleware for non-sentry requests', () => {
@@ -97,6 +97,7 @@ describe('metroMiddleware', () => {
   describe('stackFramesContextMiddleware', () => {
     let request: any;
     let response: any;
+    const next = jest.fn();
 
     let testData: string = '';
 
@@ -124,43 +125,43 @@ describe('metroMiddleware', () => {
     });
 
     it('should set request encoding to utf8', async () => {
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(request.setEncoding).toHaveBeenCalledWith('utf8');
     });
 
     it('should return 400 for missing request body', async () => {
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(400);
       expect(response.end).toHaveBeenCalledWith('Invalid request body. Expected a JSON object.');
     });
 
     it('should return 400 for invalid request body', async () => {
       testData = 'invalid';
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(400);
     });
 
     it('should return 400 when stack is not an array', async () => {
       testData = '{"stack": "not an array"}';
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(400);
       expect(response.end).toHaveBeenCalledWith('Invalid stack frames. Expected an array.');
     });
 
     it('should set content type to application/json for valid response', async () => {
       testData = '{"stack":[]}';
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.setHeader).toHaveBeenCalledWith('Content-Type', 'application/json');
     });
 
     it('should return 200 for valid empty stack', async () => {
       testData = '{"stack":[]}';
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(200);
     });
@@ -181,7 +182,7 @@ describe('metroMiddleware', () => {
 
       mockReadFileOnce(readFileSpy, 'test.js', 'line1\nline2\nline3\nline4\nline5');
 
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(200);
       expect(JSON.parse(response.end.mock.calls[0][0])).toEqual({
@@ -213,7 +214,7 @@ describe('metroMiddleware', () => {
         ],
       } satisfies { stack: StackFrame[] });
 
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(readFileSpy).not.toHaveBeenCalled();
       expect(response.statusCode).toBe(200);
@@ -243,7 +244,7 @@ describe('metroMiddleware', () => {
         ],
       } satisfies { stack: StackFrame[] });
 
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(readFileSpy).not.toHaveBeenCalled();
       expect(response.statusCode).toBe(200);
@@ -295,7 +296,7 @@ describe('metroMiddleware', () => {
         ],
       } satisfies { stack: StackFrame[] });
 
-      await stackFramesContextMiddleware(request, response);
+      await stackFramesContextMiddleware(request, response, next);
 
       expect(response.statusCode).toBe(200);
       expect(JSON.parse(response.end.mock.calls[0][0])).toEqual({