Allow OTEL instrumenter to work even with no DSN.

[jwhitaker-gridcog]

Allow OTEL instrumenter to work even with no DSN.

Context: we are writing tests for our Sentry integration itself, setting up a client like

events = []
c = sentry_sdk.Client(dsn=None, instrumenter='otel', transport=events.append)

, and verifying that events contains spans from OpenTelemetry such as

with tracer.start_as_current_span('fn'):
   raise Exception('boo')

assert events = [...]

This currently doesn't work because the Sentry OTEL integration has some hacks poking into the client and hard-returning if DSN is None.

I conjecture the hard-return can be removed - the check-DSN-to-avoid-sentry-otel-loops logic still works even without the DSN check in on_start().

[cursor]

Bug: DSN Parsing Error Causes Application Crash

Removing the DSN validation try/except block in on_start() means malformed (non-None) DSN strings are no longer handled gracefully. This causes _is_sentry_span() to raise an unhandled exception when attempting to parse the DSN, potentially crashing the application.

sentry_sdk/integrations/opentelemetry/span_processor.py#L111-L125

sentry-python/sentry_sdk/integrations/opentelemetry/span_processor.py

Lines 111 to 125 in dde625f

	def on_start(self, otel_span, parent_context=None):
	# type: (OTelSpan, Optional[context_api.Context]) -> None
	client = get_client()
	if client.options["instrumenter"] != INSTRUMENTER.OTEL:
	return
	if not otel_span.get_span_context().is_valid:
	return
	if self._is_sentry_span(otel_span):
	return
	trace_data = self._get_trace_data(otel_span, parent_context)

 

---