Draft
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PoC showing how Effect can be integrated into Sentry. This is now inside
@sentry/coreexported as@sentry/core/effectto make the build work. Here we had to change the rollup config to make it work, which I personally want to avoid.Usage
The basic usage in an effect world would look like this:
For ESM and node we need to
--importthe instrument file to make it work:node --import ./src/instrument.js effect-app.jsand the main entrypoint of Effect would look like this:Open questions
@sentry/core/effectthe way to go or is@sentry/effectthe better movepackages/core/rollup.npm.config.mjs, maybe we need something more genericeffectasoptionalPeerDependencyok?Todos
ErrorReporter