-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(consola): Enhance Consola integration to extract first-param object as searchable attributes #19534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+429
−51
Merged
feat(consola): Enhance Consola integration to extract first-param object as searchable attributes #19534
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
27eb3ed
fix(consola): Normalize extra keys from consola
s1gr1d 7e136db
object-only tests
s1gr1d 73e9c4a
add processing functions
s1gr1d 5e20cdd
add integration tests
s1gr1d 94cd896
add integration tests
s1gr1d 282b963
do not export
s1gr1d 10f229d
Merge branch 'develop' into sig/consola-obj-keys
s1gr1d 72a2554
fix yarn.lock
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
dev-packages/node-integration-tests/suites/consola/subject-object-first.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
| import { loggingTransport } from '@sentry-internal/node-integration-tests'; | ||
| import { consola } from 'consola'; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| release: '1.0.0', | ||
| environment: 'test', | ||
| enableLogs: true, | ||
| transport: loggingTransport, | ||
| }); | ||
|
|
||
| async function run(): Promise<void> { | ||
| consola.level = 5; | ||
| const sentryReporter = Sentry.createConsolaReporter(); | ||
| consola.addReporter(sentryReporter); | ||
|
|
||
| // Object-first: args = [object, string] — first object becomes attributes, second arg is part of formatted message | ||
| consola.info({ userId: 100, action: 'login' }, 'User logged in'); | ||
|
|
||
| // Object-first: args = [object] only — object keys become attributes, message is stringified object | ||
| consola.info({ event: 'click', count: 2 }); | ||
|
|
||
| await Sentry.flush(); | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| void run(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a function that could be theoretically added by users (as a future feature). That's why this function is extra from the
processExtractedAttributes. In theory, it could just be one function.