Skip to content

Conversation

@logaretm
Copy link
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that [email protected] already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes #18199

@linear
Copy link

linear bot commented Dec 29, 2025

@logaretm logaretm changed the title ref(pino): Drop pino<9.10 support ref(node-core): Drop pino<9.10 support Dec 29, 2025
@logaretm logaretm added Meta: Breaking Package: node Issues related to the Sentry Node SDK breaking change labels Dec 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,392 - 9,285 +1%
GET With Sentry 1,770 19% 1,723 +3%
GET With Sentry (error only) 6,199 66% 6,019 +3%
POST Baseline 1,202 - 1,213 -1%
POST With Sentry 592 49% 601 -1%
POST With Sentry (error only) 1,067 89% 1,068 -0%
MYSQL Baseline 3,336 - 3,356 -1%
MYSQL With Sentry 474 14% 459 +3%
MYSQL With Sentry (error only) 2,716 81% 2,714 +0%

View base workflow run

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.82 kB - -
@sentry/browser - with treeshaking flags 23.32 kB - -
@sentry/browser (incl. Tracing) 41.6 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.19 kB - -
@sentry/browser (incl. Tracing, Replay) 80.17 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.91 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84.85 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 97.1 kB - -
@sentry/browser (incl. Feedback) 41.54 kB - -
@sentry/browser (incl. sendFeedback) 29.51 kB - -
@sentry/browser (incl. FeedbackAsync) 34.5 kB - -
@sentry/browser (incl. Metrics) 25.85 kB - -
@sentry/browser (incl. Logs) 26.07 kB - -
@sentry/browser (incl. Metrics & Logs) 26.73 kB - -
@sentry/react 26.54 kB - -
@sentry/react (incl. Tracing) 43.79 kB - -
@sentry/vue 29.29 kB - -
@sentry/vue (incl. Tracing) 43.41 kB - -
@sentry/svelte 24.84 kB - -
CDN Bundle 27.25 kB - -
CDN Bundle (incl. Tracing) 42.24 kB - -
CDN Bundle (incl. Tracing, Replay) 78.96 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 84.41 kB - -
CDN Bundle - uncompressed 80.06 kB - -
CDN Bundle (incl. Tracing) - uncompressed 125.49 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 242.03 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.79 kB - -
@sentry/nextjs (client) 46.02 kB - -
@sentry/sveltekit (client) 41.97 kB - -
@sentry/node-core 51.61 kB -0.03% -12 B 🔽
@sentry/node 161.51 kB -0.01% -11 B 🔽
@sentry/node - without tracing 93.04 kB -0.02% -10 B 🔽
@sentry/aws-serverless 108.56 kB -0.01% -8 B 🔽

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Meta: Breaking Package: node Issues related to the Sentry Node SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

3 participants