feat(core): Add option to enhance the fetch error message #18466
+600
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
approved these changes
Dec 17, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Sounds reasonable to me! Let's make sure to document the new option, thanks!
| import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers'; | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: false: enhances error for Sentry while preserving original @firefox', |
Member
There was a problem hiding this comment.
l: we're testing against all browsers here, right?
Suggested change
| 'enhanceFetchErrorMessages: false: enhances error for Sentry while preserving original @firefox', | |
| 'enhanceFetchErrorMessages: false: enhances error for Sentry while preserving original', |
| ); | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: false: enhances subdomain errors @firefox', |
Member
There was a problem hiding this comment.
Suggested change
| 'enhanceFetchErrorMessages: false: enhances subdomain errors @firefox', | |
| 'enhanceFetchErrorMessages: false: enhances subdomain errors', |
| ); | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: false: includes port in hostname @firefox', |
Member
There was a problem hiding this comment.
Suggested change
| 'enhanceFetchErrorMessages: false: includes port in hostname @firefox', | |
| 'enhanceFetchErrorMessages: false: includes port in hostname', |
| import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers'; | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: report-only: enhances error for Sentry while preserving original @firefox', |
Member
There was a problem hiding this comment.
Suggested change
| 'enhanceFetchErrorMessages: report-only: enhances error for Sentry while preserving original @firefox', | |
| 'enhanceFetchErrorMessages: report-only: enhances error for Sentry while preserving original', |
| ); | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: report-only: enhances subdomain errors @firefox', |
Member
There was a problem hiding this comment.
Suggested change
| 'enhanceFetchErrorMessages: report-only: enhances subdomain errors @firefox', | |
| 'enhanceFetchErrorMessages: report-only: enhances subdomain errors', |
| ); | ||
|
|
||
| sentryTest( | ||
| 'enhanceFetchErrorMessages: report-only: includes port in hostname @firefox', |
Member
There was a problem hiding this comment.
Suggested change
| 'enhanceFetchErrorMessages: report-only: includes port in hostname @firefox', | |
| 'enhanceFetchErrorMessages: report-only: includes port in hostname', |
Member
|
(I was thinking for a moment if it makes sense for us to only add the option to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #18449)
(closes JS-1281)
Problem
As of now, the user has no chance to disallow the manipulation of fetch errors, as we overwrite the error. This can cause problems as seen in #18449.
Solution
This adds a new option for the SDK (please be very critical about that new option here, since
fetchhas no integration this has to be added as ainitoption).alwaysis the default and acts the same as it is now, so it is acting as feature:To give the user full control of how the errors are done there are 3 settings:
Special attention to reviewers
When having
report-onlythe generated logs locally differ from the ones in Sentry. I am not quite sure if that would cause any problems. This is the only question which I don't have the answer to yetAlternative
In case the size increase is too much, we can also have a boolean that disables that (which is on by default)