feat(core): [Global Attributes 2]Wire scope attributes into LoggerApi and MetricsApi#5120
Open
adinauer wants to merge 2 commits intofeat/scope-attributesfrom
Open
feat(core): [Global Attributes 2]Wire scope attributes into LoggerApi and MetricsApi#5120adinauer wants to merge 2 commits intofeat/scope-attributesfrom
adinauer wants to merge 2 commits intofeat/scope-attributesfrom
Conversation
Extract factory methods SentryAttributeType.inferFrom and SentryLogEventAttributeValue.fromAttribute to reduce duplication. Apply scope attributes to log and metric events automatically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Performance metrics 🚀
|
Member
Author
|
PR Stack (Global Attributes):
|
This was referenced Feb 26, 2026
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #5118
📜 Description
Wire scope-level attributes into
LoggerApiandMetricsApiso they are automatically included in log and metric events. Also extracts duplicated type-inference logic into reusable factory methods:SentryAttributeType.inferFrom(Object)— infers the attribute type from a valueSentryLogEventAttributeValue.fromAttribute(SentryAttribute)— creates an attribute value from aSentryAttribute, inferring the type if not explicitly setBoth
LoggerApiandMetricsApinow read scope attributes viagetCombinedScopeView().getAttributes()and include them as the base set of attributes on every log/metric event (user-provided attributes take precedence).💡 Motivation and Context
With scope-level attributes added in #5118, this PR completes the integration by ensuring those attributes flow through to logs and metrics automatically. The factory method extraction removes duplicated
getType()methods that existed in bothLoggerApiandMetricsApi.💚 How did you test it?
LoggerApiandMetricsApicontinue to pass📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
main